Title, description and id are now correctly fetched over ActivityPub. But the library we are using is a mess, and the code is extremely ugly. Also our database and logic needs a good number of changes to deal with federation (like we cant use simple numeric IDs).

  • mariusor
    link
    fedilink
    arrow-up
    4
    ·
    5 years ago

    Why do you think you’re not able to use numeric ids?

    • nutomicOPA
      link
      fedilink
      arrow-up
      4
      ·
      5 years ago

      Well right now Lemmy uses only the numeric ID to reference communities. Thats not gonna work with federation because there will be multiple communities with ID 1 for example. We could use something like id@instance but that looks ugly, so better go with name@instance directly. Though what I’ve seen most are randomized IDs like https://radical.town/@felix/103279326280720653 (okay thats also numeric, I was thinking of Peertube IDs like https://peertube.social/videos/watch/b93a8c16-cc62-4c31-9556-ea71a27d80ee when I wrote that).

      Btw how far along are you with implementing federation?

      • mariusor
        link
        fedilink
        arrow-up
        6
        ·
        5 years ago

        Not closer than I was a month ago sadly. I got bogged down in some C2S details.

        That being said, my library has pretty much interchangeable C2S - S2S behaviour. Ie, the dev needs not worry about the distinction too much.

        Returning to the ID problem. In ActivityPub the ID you expose when federating needs to be a fully qualified IRI, so multiple instances with containing the local numeric ID 1 should not a problem. Otherwise collisions would happen even if using UUIDs or some other non numeric sequence logic.

          • mariusor
            link
            fedilink
            arrow-up
            4
            ·
            5 years ago

            Well, I’m working on federation on another project. :) Thank you, though.

        • nutomicOPA
          link
          fedilink
          arrow-up
          4
          ·
          5 years ago

          Okay so I’m more thinking of the URLs that are visible to the user, not of ActivityPub. Still need to get more familiar with that.

          • AgreeableLandscape
            link
            fedilink
            arrow-up
            3
            ·
            edit-2
            5 years ago

            For user-visible URLs, keep in mind that having plaintext names (so something like https://lemmy.ml/c/community@communism.lemmy.ml) is good for both human readability and search engine optimization.

  • oriond
    link
    fedilink
    arrow-up
    3
    ·
    5 years ago

    Thank you so much! Keep up the good work!