• @nutomicOPA
    2•4 years ago

    /u/dessalines I think we should make the whole area in my screenshot clickable to open the embed. Right now it looks confusing, you have the image that opens the embed, two seperate links that open the link in a new tab, and additional text.

    • DessalinesA
      2•4 years ago

      I thought about that, but I wanted all the text to be selectable, plus the description if you check out some others will often have other links in it that are clickable.

      I’m debating whether the image should by default open up the link (like everything else does), or leave it as it is now where it expands the embed. The other image clicks are an expando so it made sense to do that for this one too.

      • @nutomicOPA
        1•4 years ago

        If someone wants to select something or click a link in the description, they should really follow the link. Otherwise we will end up embedding the entire target page. And having even more clickable links is just way too confusing.

        I think the whole part in my screenshot should open the embed, maybe closing itself once the embed is opened. Usually the embed itself has a link to open the website (and we have the link above as well). Right now I count 3 seperate links to the same URL (and also the same picture twice).

        • DessalinesA
          1•4 years ago

          Good point about the pictures, I’ll pry remove the picture from the card entirely, since if there is one, it’ll be in the post title anyway.

          But here’s a good example of why I want to keep the link text.

          There also usually isn’t an embed, only a url.

          It does make sense to me to have the expando hide the card, I’ll try that out too.

          I’m still torn about having every link by default do the embed… at least with RES there’s an explicit expando button like I have, so you know when you’re doing it.

          • @nutomicOPA
            1•4 years ago

            Right, twitter/mastodon type links should be handled completely differently from video links. Those should definitely have the text.

            Is there any reason not to have the embed? Are you worried about the space it takes or something?

            • DessalinesA
              2•4 years ago

              I don’t wanna write exceptions for different providers, wayyy too much work.

              I deployed a new one w/o images to https://test.lemmy.ml/ , check out some of those examples and tell me what you think.

              edit: its deployed here now v0.6.22

              • @nutomicOPA
                1•4 years ago

                Hmm I understand not making it too complicated, but I still dont like the current behaviour that much. Way too hard to find the embed button, it should probably be the biggest one. Check out how Mastodon does it, the entire preview is replaced by the embed, the preview doesnt even have a clickable link.

                Edit: Okay I’m wrong, Mastodon has two seperate buttons on the preview, one for play (embed), and one to open the link. Plus some additional text. Anyway it looks much nicer, and its obvious what each option will do.

            • DessalinesA
              2•4 years ago

              I show the plus button when there is an iframe / embed html. I’m just reticent to have the links do an iframe expansion, rather than an expando + button like I have now.