It does make sense to me to have the expando hide the card, I’ll try that out too.
I’m still torn about having every link by default do the embed… at least with RES there’s an explicit expando button like I have, so you know when you’re doing it.
I show the plus button when there is an iframe / embed html. I’m just reticent to have the links do an iframe expansion, rather than an expando + button like I have now.
Hmm I understand not making it too complicated, but I still dont like the current behaviour that much. Way too hard to find the embed button, it should probably be the biggest one. Check out how Mastodon does it, the entire preview is replaced by the embed, the preview doesnt even have a clickable link.
Edit: Okay I’m wrong, Mastodon has two seperate buttons on the preview, one for play (embed), and one to open the link. Plus some additional text. Anyway it looks much nicer, and its obvious what each option will do.
Good point about the pictures, I’ll pry remove the picture from the card entirely, since if there is one, it’ll be in the post title anyway.
But here’s a good example of why I want to keep the link text.
There also usually isn’t an embed, only a url.
It does make sense to me to have the expando hide the card, I’ll try that out too.
I’m still torn about having every link by default do the embed… at least with RES there’s an explicit expando button like I have, so you know when you’re doing it.
Right, twitter/mastodon type links should be handled completely differently from video links. Those should definitely have the text.
Is there any reason not to have the embed? Are you worried about the space it takes or something?
I show the plus button when there is an iframe / embed html. I’m just reticent to have the links do an iframe expansion, rather than an expando
+button like I have now.I don’t wanna write exceptions for different providers, wayyy too much work.
I deployed a new one w/o images to https://test.lemmy.ml/ , check out some of those examples and tell me what you think.
edit: its deployed here now
v0.6.22Hmm I understand not making it too complicated, but I still dont like the current behaviour that much. Way too hard to find the embed button, it should probably be the biggest one. Check out how Mastodon does it, the entire preview is replaced by the embed, the preview doesnt even have a clickable link.
Edit: Okay I’m wrong, Mastodon has two seperate buttons on the preview, one for play (embed), and one to open the link. Plus some additional text. Anyway it looks much nicer, and its obvious what each option will do.