• Cornelius
    link
    fedilink
    arrow-up
    9
    ·
    18 days ago

    And you guessed it, they copied that ignored-annotation, too, complete with the comment “//TODO currently broken”. The test they implemented was not run, not even once.

    Junior dev here, this is the kind of stuff that is supposed to prompt you to ask questions. Literally one slack message when you see it, and give it a few hours for whenever you have time to see it and respond. I know it’s annoying messaging y’all with stuff but… C’mon you gotta do it sometimes, especially if it’s something you can reasonably predict will come up in review or is a simple question that doesn’t require a lot of time to answer.

    • Ephera
      link
      fedilink
      arrow-up
      5
      ·
      18 days ago

      Yeah, we had a hard bottleneck for seniors, so they kind of got told to walk on their own as much as they can, but after just two weeks or so, I had to push hard against that, because they would frequently walk into wrong directions and then rectifying that would cost me significantly more time. At one point, I had to review a story three times, because they misunderstood the goal twice.

      Similarly, we had a student, who would run off doing things for two weeks, and then suddenly she’d come up to you and tell you that she did this and this and that and now she’s stuck.
      And then if the second ‘this’ was an incorrect decision, you have to sit down with her in that exact moment and redo a lot of her work to get everything back on track.

      So, yeah, juniors who know when to ask questions are extremely helpful. Otherwise I have to poll them for questions, which takes up time, too.