rglullis@communick.news to Experienced Devs@programming.devEnglish · 19 hours agoWhile reviewing a PR, you find some piece of code that seems to work perfectly well, but some functions are written in a style that you don't particularly favor. What do you do?cupid.careersexternal-linkmessage-square12fedilinkarrow-up124arrow-down11
arrow-up123arrow-down1external-linkWhile reviewing a PR, you find some piece of code that seems to work perfectly well, but some functions are written in a style that you don't particularly favor. What do you do?cupid.careersrglullis@communick.news to Experienced Devs@programming.devEnglish · 19 hours agomessage-square12fedilink
minus-squareAlexlinkfedilinkarrow-up10·16 hours agoThe link refers to it being a style in an area that isn’t covered. In that case I’d favour consistency with the current code it’s touching and open an issue to update the style guide to cover the new area.
The link refers to it being a style in an area that isn’t covered. In that case I’d favour consistency with the current code it’s touching and open an issue to update the style guide to cover the new area.