This would have been great information for about five minutes ago ;-)

Do not upgrade to linux 6.1.61-1. Worst mistake of my life.

That probably explains why my NixOS was borked. Thankfully, I’m on 6.1.65.

Its in several more kernels than that.

That patch was backported into known (and probably more): v5.10.202, v5.15.140, v6.1.64

ext4 data corruption in 6.1 stable tree (was Re: [PATCH 5.15 000/297] 5.15.140-rc1 review

So I’ve got back to this and the failure is a subtle interaction between iomap code and ext4 code. In particular that fact that commit 936e114a245b6 (“iomap: update ki_pos a little later in iomap_dio_complete”) is not in stable causes that file position is not updated after direct IO write and thus we direct IO writes are ending in wrong locations effectively corrupting data. The subtle detail is that before this commit if ->end_io handler returns non-zero value (which the new ext4 ->end_io handler does), file pos doesn’t get updated, after this commit it doesn’t get updated only if the return value is < 0.

The commit got merged in 6.5-rc1 so all stable kernels that have 91562895f803 (“ext4: properly sync file size update after O_SYNC direct IO”) before 6.5 are corrupting data - I’ve noticed at least 6.1 is still carrying the problematic commit. Greg, please take out the commit from all stable kernels before 6.5 as soon as possible, we’ll figure out proper backport once user data are not being corrupted anymore. Thanks!

https://lore.kernel.org/stable/20231205122122.dfhhoaswsfscuhc3@quack3/

Hm, I just upgraded two hours ago and put my laptop to standby. When I don’t reboot until the fix is there and update before rebooting I should be fine. Right?

Holly smok. :/

Thanks for the heads up.

Good thing I use xfs I guess

Whew! Kernel: 6.1.0-16-amd64 and I just recently had a kernel update I think. Debian.

deleted by creator