Sometimes. Depends on context. If the flaws make a solution unworkable, then they’re worth bringing up. If you support the concept but would also like the flaws to be worked on, then it’s worth tactfully bringing up. If no solution other than absolute perfection will satisfy you, shut the fuck up.
There’s a lot of idiots and bad actors sabotaging good solutions because they want perfect solutions, and then we end up getting no solutions. So yeah. Don’t do that.
Agree with this. I think tactfully pointing out minor issues you see can be helpful because the implementor is closer to the problem and may have just overlooked the issue and can come up with a solution easily. I’ve been on the giving and receiving end of this, and so long as everyone is behaving professionally, it’s always been helpful.
On the “tactful” note, I’ll generally say something like: “I don’t have a solution, but I see problem. I don’t know that this is reason enough to hold up this PR. I’ll leave it up to you.”
Sometimes. Depends on context. If the flaws make a solution unworkable, then they’re worth bringing up. If you support the concept but would also like the flaws to be worked on, then it’s worth tactfully bringing up. If no solution other than absolute perfection will satisfy you, shut the fuck up.
There’s a lot of idiots and bad actors sabotaging good solutions because they want perfect solutions, and then we end up getting no solutions. So yeah. Don’t do that.
Agree with this. I think tactfully pointing out minor issues you see can be helpful because the implementor is closer to the problem and may have just overlooked the issue and can come up with a solution easily. I’ve been on the giving and receiving end of this, and so long as everyone is behaving professionally, it’s always been helpful.
On the “tactful” note, I’ll generally say something like: “I don’t have a solution, but I see problem. I don’t know that this is reason enough to hold up this PR. I’ll leave it up to you.”