leds@feddit.dk to Programmer Humor@programming.dev · 11 months agoDO NOT MERGEfeddit.dkimagemessage-square32fedilinkarrow-up1250arrow-down18file-text
arrow-up1242arrow-down1imageDO NOT MERGEfeddit.dkleds@feddit.dk to Programmer Humor@programming.dev · 11 months agomessage-square32fedilinkfile-text
minus-squareaMockTie@beehaw.orglinkfedilinkarrow-up22arrow-down1·11 months agoWhy did they submit this as a pull request in the first place? Just commit it to a WIP branch until it’s ready to merge. Am I missing something?
minus-squarebrisk@aussie.zonelinkfedilinkarrow-up30·11 months agoProbably to get some other benefitof the PR system, such as CI tests
minus-squareleds@feddit.dkOPlinkfedilinkarrow-up10·11 months agoDoes gerrit have a draft state? In azure devops you can mark PR as draft , won’t trigger any builds but you can still start them manually
minus-squarebeeng@discuss.tchncs.delinkfedilinkarrow-up4·11 months ago manually This is probably why the dev created a PR, less clicks
minus-squaresf1tzp@programming.devlinkfedilinkarrow-up2·11 months agoI don’t remember if it did when I used it. Our convention was to -2 your own change until it was ready to go 😅
minus-squareNotSteve_@lemmy.calinkfedilinkarrow-up7·11 months agoI do this often. It’s useful if you want to send it to your coworker for some early feedback or as others have said, have the CI run
minus-squareDr. Jenkem@lemmy.blugatch.tubelinkfedilinkEnglisharrow-up4·edit-211 months agoIt’s been a while since I’ve worked with AOSP, but I had always understood it to be some weird shit with Google’s internal processes. The “do not merge” commits are all over the AOSP, or at least they used to be.
Why did they submit this as a pull request in the first place? Just commit it to a WIP branch until it’s ready to merge. Am I missing something?
Probably to get some other benefitof the PR system, such as CI tests
Does gerrit have a draft state? In azure devops you can mark PR as draft , won’t trigger any builds but you can still start them manually
This is probably why the dev created a PR, less clicks
I don’t remember if it did when I used it. Our convention was to -2 your own change until it was ready to go 😅
I do this often. It’s useful if you want to send it to your coworker for some early feedback or as others have said, have the CI run
It’s been a while since I’ve worked with AOSP, but I had always understood it to be some weird shit with Google’s internal processes. The “do not merge” commits are all over the AOSP, or at least they used to be.